Create Spindle_monitor.comp #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component to trigger an output based on the commanded vs actual speed of spindle. Useful for triggering E-stop if spindle speed drops below set threshold (cutter jam) to avoid damage. Required lowpass component to filter spindle-feedback input pin during testing. Originally written by Andypugh, modified and tested by myself.
|
I’m not all that familiar with the git process but I believe I committed it to the wrong spot in the directory. Should be in src/hal/components.
…Sent from my iPhone
On Aug 27, 2018, at 1:31 PM, Sebastian Kuzminsky ***@***.***> wrote:
Merged #492 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks for the heads up -- I should have checked that. I moved the file where it belongs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component to trigger an output based on the commanded vs actual speed of spindle. Useful for triggering E-stop if spindle speed drops below set threshold (cutter jam) to avoid damage.
Required lowpass component to filter spindle-feedback input pin during testing.
Originally written by Andypugh, modified and tested by myself.